Messages in this thread | | | Date | Tue, 15 Oct 2013 11:25:38 -0400 | From | Tejun Heo <> | Subject | Re: [PATCH v2 05/12] cpuset: use effective cpumask to build sched domains |
| |
On Fri, Oct 11, 2013 at 05:50:38PM +0800, Li Zefan wrote: > @@ -930,10 +931,21 @@ static void update_cpumasks_hier(struct cpuset *cs, struct cpuset *trialcs, > > update_tasks_cpumask(cp, heap); > > + /* > + * If the effective cpumask of any non-empty cpuset is > + * changed, we need to rebuild sched domains. > + */ > + if (!cpumask_empty(cp->cpus_allowed) && > + is_sched_load_balance(cp)) > + need_rebuild_sched_domains = true; > +
Can you please explain *why* this change is being made in the patch description? The patch description doesn't give me anything and the comment explain "what" but not why it's moved from update_cpumask() into this function with an extra condition.
Thanks.
-- tejun
| |