lkml.org 
[lkml]   [2013]   [Oct]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 11/12] mm, thp, tmpfs: enable thp page cache in tmpfs
Date
Ning Qu wrote:
> Signed-off-by: Ning Qu <quning@gmail.com>
> ---
> mm/Kconfig | 4 ++--
> mm/shmem.c | 5 +++++
> 2 files changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/mm/Kconfig b/mm/Kconfig
> index 562f12f..4d2f90f 100644
> --- a/mm/Kconfig
> +++ b/mm/Kconfig
> @@ -428,8 +428,8 @@ config TRANSPARENT_HUGEPAGE_PAGECACHE
> help
> Enabling the option adds support hugepages for file-backed
> mappings. It requires transparent hugepage support from
> - filesystem side. For now, the only filesystem which supports
> - hugepages is ramfs.
> + filesystem side. For now, the filesystems which support
> + hugepages are: ramfs and tmpfs.
>
> config CROSS_MEMORY_ATTACH
> bool "Cross Memory Support"
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 75c0ac6..50a3335 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -1672,6 +1672,11 @@ static struct inode *shmem_get_inode(struct super_block *sb, const struct inode
> break;
> case S_IFREG:
> inode->i_mapping->a_ops = &shmem_aops;
> + /*
> + * TODO: make tmpfs pages movable
> + */
> + mapping_set_gfp_mask(inode->i_mapping,
> + GFP_TRANSHUGE & ~__GFP_MOVABLE);

Unlike ramfs, tmpfs pages are movable before transparent page cache
patchset.
Making tmpfs pages non-movable looks like a big regression to me. It need
to be fixed before proposing it upstream.

--
Kirill A. Shutemov


\
 
 \ /
  Last update: 2013-10-15 13:41    [W:2.301 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site