[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH v2] platform: x86: asus-wmi: add fan control
On Mon, Oct 14, 2013 at 6:22 PM, Matthew Garrett <> wrote:
> On Mon, Oct 14, 2013 at 06:18:36PM -0500, Felipe Contreras wrote:
>> On Mon, Oct 14, 2013 at 10:52 AM, Matthew Garrett <> wrote:
>> > It wouldn't be appropriate to alter the firmware behaviour by default,
>> > but yeah, that's the kind of thing that the thermal framework exists to
>> > do.
>> Well, how do I do that? The driver is up and running, and I can
>> manually set different fan speeds, however nothing seems to happen
>> automatically when the temperature increases.
> The easiest is to just do it from userspace. I think Intel have some
> code for doing this, but I haven't looked at the thermal code for years.

That defeats the purpose of the whole thermal binding infrastructure.

>> > I don't think you can easily register multiple drivers for the same WMI
>> > device.
>> I don't mean this one, I mean the standalone one. Actually, the first
>> one I sent doesn't require all this system memory stuff.
> Banging EC registers directly is the wrong thing to do. Going via WMI is
> correct.

I'm not going to bother arguing against your absolutist rhetoric. The
fact is one patch can be applied, the other can't. Besides, nobody
said anything about banging EC registers directly.

Felipe Contreras

 \ /
  Last update: 2013-10-15 01:41    [W:0.052 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site