Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] init: fix in-place parameter modification regression | Date | Mon, 14 Oct 2013 18:06:23 +1030 |
| |
Krzysztof Mazur <krzysiek@podlesie.net> writes: > Before commit 026cee0086fe1df4cf74691cf273062cc769617d > ("params: <level>_initcall-like kernel parameters") the __setup > parameter parsing code could modify parameter in the > static_command_line buffer and such modifications were kept. After > that commit such modifications are destroyed during per-initcall level > parameter parsing because the same static_command_line buffer is used > and only parameters for appropriate initcall level are parsed. > > That change broke at least parsing "ubd" parameter in the ubd driver > when the COW file is used. > > Now the separate buffer is used for per-initcall parameter parsing, > like in parsing early params.
How about just removing "strcpy(static_command_line, saved_command_line);" from do_initcall_level altogether? We already initialize it in setup_command_line().
Cheers, Rusty.
| |