lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/efi: Add EFI framebuffer earlyprintk support

* H. Peter Anvin <hpa@zytor.com> wrote:

> On 10/12/2013 10:49 AM, Ingo Molnar wrote:
> >
> >>>> +static void early_efi_write_char(void *dst, char c, int h)
> >>>> +{
> >>>> + const u8 *src;
> >>>> + u32 fgcolor = 0xaaaaaa;
> >>>
> >>> That's RGB grey, right? Why not 0xffffff for a very visible white?
> >>
> >> The VGA earlyprintk code uses the equivalent grey, AFAIK, which is why I
> >> picked this value.
> >
> > The VGA code should be changed to white too I suspect ;-)
> >
>
> For compatibility with the classical text console we use light grey as
> the default color and a double-stroked font (which was necessary on the
> CGA display since it didn't have enough bandwidth to handle
> single-stroked fonts well). The problem with changing that to white is
> that you end up with a mismatch between the earlyprintk console and the
> "real" console, *or* we change the behavior of everyone's consoles...

Btw., I have no problem at all with making the early console look separate
and making it clear when we switch to the 'real' console.

earlyprintk is a debug method, and more information can only be good.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-14 10:21    [W:0.083 / U:7.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site