lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 10/10] intel_mid: Moved SFI related code to intel_mid_sfi.c
On 10/14/2013 09:38 AM, H. Peter Anvin wrote:
> On 10/11/2013 08:43 PM, David Cohen wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Moved SFI specific parsing/handling code to intel_mid_sfi.c. This will enable
>> us to reuse our intel-mid code for platforms that supports firmware interfaces
>> other than SFI (like ACPI).
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
>> ---
>> arch/x86/include/asm/intel-mid.h | 1 +
>> arch/x86/platform/intel-mid/Makefile | 5 +-
>> arch/x86/platform/intel-mid/intel-mid.c | 450 --------------------------
>> arch/x86/platform/intel-mid/intel_mid_sfi.c | 485 ++++++++++++++++++++++++++++
>> 4 files changed, 489 insertions(+), 452 deletions(-)
>> create mode 100644 arch/x86/platform/intel-mid/intel_mid_sfi.c
>>
>
> Why not just sfi.c? It is already in a directly named intel-mid.
>
> I presume otherwise this is just code movement... I haven't verified
> that, but it looked like it.

Yes, it is and I agree sfi.c seems better. Changing it for next patch
set too.

Br, David Cohen

>
> -hpa
>



\
 
 \ /
  Last update: 2013-10-14 19:01    [W:0.128 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site