Messages in this thread | | | Date | Mon, 14 Oct 2013 16:44:02 +0100 | From | Catalin Marinas <> | Subject | Re: [RFT PATCH v2 3/4] arm64: reduce duplicated code when saving/restoring FPSIMD for signal handling |
| |
On Sun, Oct 13, 2013 at 03:20:19PM +0100, Jiang Liu wrote: > +void fpsimd_prepare_sigctx(struct fpsimd_state *state) > +{ > + /* dump the hardware registers to the fpsimd_state structure */ > + fpsimd_save_state(state); > + fpsimd_clear_fpsr(); > +}
What don't particularly like is that you save the FP context and then corrupt it. Can we get preempted after this function and before we save it on the signal stack?
-- Catalin
| |