Messages in this thread | | | Date | Mon, 14 Oct 2013 15:48:09 +0200 | From | Peter Zijlstra <> | Subject | Re: [RFC][PATCH 3/7] sched: power: go_faster/slower power driver hints |
| |
On Fri, Oct 11, 2013 at 06:19:13PM +0100, Morten Rasmussen wrote: > +static inline void inc_cpu_capacity(int cpu) > +{ > + if (weighted_cpuload(cpu) > power_of(cpu)) > + go_faster(cpu, 0); > +} > + > +static inline void dec_cpu_capacity(int cpu) > +{ > + if (weighted_cpuload(cpu) < power_of(cpu)) > + go_slower(cpu, 0); > +}
It seems wrong to me to use weighted_cpuload() here; that contains the task weight, which is irrelevant to power usage. I would expect a pure utilization term here.
Something like:
se->avg.runnable_avg_sum / se->avg.runnable_avg_period
| |