lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/14] sched: SCHED_DEADLINE structures & implementation.
    On Mon, Oct 14, 2013 at 12:43:35PM +0200, Juri Lelli wrote:
    > +static void update_curr_dl(struct rq *rq)
    > +{
    > + struct task_struct *curr = rq->curr;
    > + struct sched_dl_entity *dl_se = &curr->dl;
    > + u64 delta_exec;
    > +
    > + if (!dl_task(curr) || !on_dl_rq(dl_se))
    > + return;
    > +
    > + /*
    > + * Consumed budget is computed considering the time as
    > + * observed by schedulable tasks (excluding time spent
    > + * in hardirq context, etc.)
    > + */
    > + delta_exec = rq->clock_task - curr->se.exec_start;

    Oh, cute.. So we compute deadlines from rq->clock but compute runtime
    from rq->clock_task.

    So won't that give funny results in that clock_task is generally slower
    than clock; so people get more 'time'.

    Maybe there's some illumination on this point further on; I'll continue
    reading.


    \
     
     \ /
      Last update: 2013-10-14 14:01    [W:2.215 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site