lkml.org 
[lkml]   [2013]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [tip:x86/kaslr] x86, relocs: Add more per-cpu gold special cases

* Ingo Molnar <mingo@kernel.org> wrote:

> * tip-bot for Michael Davidson <tipbot@zytor.com> wrote:
>
> > Commit-ID: d751c169e9a6f0f853346f1184881422bd10b3c2
> > Gitweb: http://git.kernel.org/tip/d751c169e9a6f0f853346f1184881422bd10b3c2
> > Author: Michael Davidson <md@google.com>
> > AuthorDate: Thu, 10 Oct 2013 18:39:54 -0700
> > Committer: H. Peter Anvin <hpa@linux.intel.com>
> > CommitDate: Sun, 13 Oct 2013 03:11:57 -0700
> >
> > x86, relocs: Add more per-cpu gold special cases
>
> I'm quite sure that one of the recent x86/kaslr changes causes this
> early x86-64 crash:

excluding tip:x86/kaslr fixes the crash. So it's one of these commits:

6e6a4932b0f5 x86, boot: Rename get_flags() and check_flags() to *_cpuflags()
6145cfe394a7 x86, kaslr: Raise the maximum virtual address to -1 GiB on x86_64
f32360ef6608 x86, kaslr: Report kernel offset on panic
82fa9637a2ba x86, kaslr: Select random position from e820 maps
5bfce5ef55cb x86, kaslr: Provide randomness functions
8ab3820fd5b2 x86, kaslr: Return location from decompress_kernel
dd78b97367bd x86, boot: Move CPU flags out of cpucheck
d751c169e9a6 x86, relocs: Add more per-cpu gold special cases

One guess would be:

dd78b97367bd x86, boot: Move CPU flags out of cpucheck

That commit is crazy large - it should be done in at least two steps:

- first the movement to cpuflags.c
- the PIC-safe refactoring

Also, checking:

82fa9637a2ba x86, kaslr: Select random position from e820 maps

I see:

+#ifdef CONFIG_X86_64
+#define memptr long
+#else
+#define memptr unsigned
+#endif

wtf? That should really be cleaned up while we are touching that code.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-14 12:21    [W:0.095 / U:6.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site