lkml.org 
[lkml]   [2013]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] KEYS: Fix a race between negating a key and reading the error set
Date
Jeff Layton <jlayton@redhat.com> wrote:

> > - if (kflags & (1 << KEY_FLAG_NEGATIVE))
> > + if (kflags & (1 << KEY_FLAG_NEGATIVE)) {
>
> Not specifically related to this bug, but why are you open-coding
> test_bit() here and elsewhere?

Because kflags is read once and kept in a variable. Might not be necessary -
and I should probably use ACCESS_ONCE() when I do.

David


\
 
 \ /
  Last update: 2013-10-12 01:01    [W:0.049 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site