Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] KEYS: Fix a race between negating a key and reading the error set | Date | Fri, 11 Oct 2013 23:51:46 +0100 |
| |
Jeff Layton <jlayton@redhat.com> wrote:
> > - if (kflags & (1 << KEY_FLAG_NEGATIVE)) > > + if (kflags & (1 << KEY_FLAG_NEGATIVE)) { > > Not specifically related to this bug, but why are you open-coding > test_bit() here and elsewhere?
Because kflags is read once and kept in a variable. Might not be necessary - and I should probably use ACCESS_ONCE() when I do.
David
| |