Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCHSET 0/8] perf tools: Fix scalability problem on callchain merging (v5) | Date | Fri, 11 Oct 2013 14:51:35 -0700 |
| |
David Ahern <dsahern@gmail.com> writes:
> On 10/11/13 9:11 AM, David Ahern wrote: >> It would be nice to fix the callchain arg handler to not attempt to >> process the next argument if it is not fp or dwarf. > > Specifically, something like this which maintains syntax and default > fp option:
Yes please! This happens to me all the time too
(usually I train myself to use -g --, but i still sometimes forget)
It still wouldn't handle -ga, but naked -g seems to be the common case.
-Andi
> > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 92ca541..23d782c 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -766,8 +766,8 @@ int record_parse_callchain_opt(const struct option *opt, > opts->stack_dump_size); > #endif /* HAVE_LIBUNWIND_SUPPORT */ > } else { > - pr_err("callchain: Unknown -g option " > - "value: %s\n", arg); > + opts->call_graph = CALLCHAIN_FP; > + ret = 0; > break; > } > >
-- ak@linux.intel.com -- Speaking for myself only
| |