Messages in this thread | | | Subject | Re: [PATCH v10 12/12] tracing: define trace_dump_stack() if !CONFIG_STACKTRACE | From | Steven Rostedt <> | Date | Fri, 11 Oct 2013 16:04:48 -0400 |
| |
On Fri, 2013-10-11 at 08:32 -0500, Tom Zanussi wrote:
> Yeah, it's not easy to turn off CONFIG_STACKTRACE - I basically had to > tweak a couple Kconfigs to do it, so I could test my stacktrace trigger > CONFIG_STACKTRACE ifdefs.
If there's no way to do make it fail currently, then it's not really a problem.
> > Still, it's code that explicitly depends on CONFIG_STACKTRACE, so I > think it makes sense to ifdef it. >
If we do decided to do this, then the change belongs in include/kernel.h:
+#ifdef CONFIG_STACKTRACE extern void trace_dump_stack(int skip); +#else +static inline void trace_dump_stack(int skip) { } +#endif
But again, since CONFIG_TRACING can't be configured without CONFIG_STACKTRACE, I don't believe this change needs to be added.
You can keep it a separate patch locally to your tree for debugging, but I doesn't need to be upstream.
-- Steve
| |