Messages in this thread Patch in this message | | | Date | Fri, 11 Oct 2013 22:08:49 +0200 (CEST) | From | Roel Kluin <> | Subject | tty: incorrect test of echo_buf() result for ECHO_OP_START |
| |
Untested, but this looks like a bug to me ----------- test echo_buf() result for ECHO_OP_START
Signed-off-by: Roel Kluin <roel.kluin@gmail.com> --- diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index 7a744b6..42b6cca 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -767,7 +767,7 @@ static size_t __process_echoes(struct tty_struct *tty) * of echo overrun before the next commit), then discard enough * data at the tail to prevent a subsequent overrun */ while (ldata->echo_commit - tail >= ECHO_DISCARD_WATERMARK) { - if (echo_buf(ldata, tail == ECHO_OP_START)) { + if (echo_buf(ldata, tail) == ECHO_OP_START) { if (echo_buf(ldata, tail) == ECHO_OP_ERASE_TAB) tail += 3; else
| |