lkml.org 
[lkml]   [2013]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[ 126/135] Btrfs: reset ret in record_one_backref
    Date
    3.11-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Josef Bacik <jbacik@fusionio.com>

    commit 50f1319cb5f7690e4d9de18d1a75ea89296d0e53 upstream.

    I was getting warnings when running find ./ -type f -exec btrfs fi defrag -f {}
    \; from record_one_backref because ret was set. Turns out it was because it was
    set to 1 because the search slot didn't come out exact and we never reset it.
    So reset it to 0 right after the search so we don't leak this and get
    uneccessary warnings. Thanks,

    Signed-off-by: Josef Bacik <jbacik@fusionio.com>
    Signed-off-by: Chris Mason <chris.mason@fusionio.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/btrfs/inode.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    --- a/fs/btrfs/inode.c
    +++ b/fs/btrfs/inode.c
    @@ -2132,6 +2132,7 @@ static noinline int record_one_backref(u
    WARN_ON(1);
    return ret;
    }
    + ret = 0;

    while (1) {
    cond_resched();
    @@ -2181,8 +2182,6 @@ static noinline int record_one_backref(u
    old->len || extent_offset + num_bytes <=
    old->extent_offset + old->offset)
    continue;
    -
    - ret = 0;
    break;
    }




    \
     
     \ /
      Last update: 2013-10-11 22:21    [W:5.756 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site