Messages in this thread | | | Date | Fri, 11 Oct 2013 14:51:49 +0800 | From | Fengguang Wu <> | Subject | Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug |
| |
On Fri, Oct 11, 2013 at 07:46:55AM +0200, Ingo Molnar wrote: > > * Fengguang Wu <fengguang.wu@intel.com> wrote: > > > > Indeed. Something like the updated version below? > > > > > > [ I kept the asm_volatile_goto() naming to make sure the implicit volatile > > > is visible. ] > > > > Ingo, I applied this patch (as commit c015a7f0b746) on top of > > tip/sched/core > > > > 3354781a2184 "sched/numa: Reflow task_numa_group() to avoid a compiler warning" > > > > The below results show that it does fixed the many oops: > > Thanks Fengguang! > > I've added your Tested-by tag as well and have split the patch in two > parts: the upstream part with a -stable tag and the rmwcc.h part that goes > into the scheduler tree. > > If there are no objections I will send a pull request for the upstream > part to Linus later today.
Ingo, sorry I'm still waiting for more results to arrive so as to confirm whether the below "kernel_early_hang_without_any_printk_output" is a noise or reliably caused by the gcc patch:
+-------------------------------------------------+--------------+--------------+ | | 3354781a2184 | c015a7f0b746 | +-------------------------------------------------+--------------+--------------+ | good_boots | 9 | 8 | | BUG:kernel_early_hang_without_any_printk_output | 0 | 1 | +-------------------------------------------------+--------------+--------------+
Thanks, Fengguang
| |