Messages in this thread | | | Date | Fri, 11 Oct 2013 16:25:14 +0200 | Subject | Re: [PATCH 1/2] gpiolib: safer implementation of desc_to_gpio() | From | Linus Walleij <> |
| |
On Fri, Oct 4, 2013 at 7:59 PM, Alexandre Courbot <acourbot@nvidia.com> wrote:
> The current implementation of desc_to_gpio() relies on the chip pointer > to be set to a valid value in order to compute the GPIO number. This > was done in the hope that we can get rid of the gpio_desc global array, > but this is not happening anytime soon. > > This patch reimplements desc_to_gpio() in a fashion similar to that of > gpio_to_desc(). As a result, desc_to_gpio(gpio_to_desc(gpio)) == gpio is > now always true. This allows to call desc_to_gpio() on non-initialized > descriptors as some error-handling code currently does. > > Signed-off-by: Alexandre Courbot <acourbot@nvidia.com> > Reported-by: Dr. H. Nikolaus Schaller <hns@goldelico.com>
Patch applied.
Yours, Linus Walleij
| |