lkml.org 
[lkml]   [2013]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3] USB: gadget: s3c-hsotg: add isochronous transfers support
Hi,

On Fri, Oct 11, 2013 at 08:23:35AM +0200, Robert Baldyga wrote:
> Hello,
>
> On 10/10/2013 06:04 PM, Felipe Balbi wrote:
> > Hi,
> >
> > On Wed, Oct 09, 2013 at 08:41:57AM +0200, Robert Baldyga wrote:
> >> @@ -2616,14 +2630,19 @@ static int s3c_hsotg_ep_enable(struct usb_ep *ep,
> >> s3c_hsotg_set_ep_maxpacket(hsotg, hs_ep->index, mps);
> >>
> >> /* default, set to non-periodic */
> >> + hs_ep->isochronous = 0;
> >> hs_ep->periodic = 0;
> >> hs_ep->halted = 0;
> >
> > this hunk doesn't apply because of this hs_ep->halted line, which patch
> > does this depend on ?
> >
> it depends on http://www.spinics.net/lists/linux-usb/msg94025.html

I'll fix it up by hand this time, but new features shouldn't (ideally)
directly depend on fixes which you just wrote.

cheers

--
balbi
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2013-10-11 16:01    [W:0.051 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site