Messages in this thread | | | Date | Sat, 12 Oct 2013 10:58:07 +0800 | From | Michael wang <> | Subject | Re: [RFC][PATCH 3/7] sched: power: go_faster/slower power driver hints |
| |
Hi, Morten
On 10/12/2013 01:19 AM, Morten Rasmussen wrote: [snip] > > @@ -5743,6 +5772,7 @@ static void run_rebalance_domains(struct softirq_action *h) > */ > nohz_idle_balance(this_cpu, idle); > > + inc_cpu_capacity(this_cpu);
Just wondering is this check necessary here? if rq get more tasks during the balance, enqueue_task() should already do the check each time when we move_task(), isn't it?
Regards, Michael Wang
> power_late_callback(this_cpu); > } > > diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h > index 907a967..88e7968 100644 > --- a/kernel/sched/sched.h > +++ b/kernel/sched/sched.h > @@ -1367,8 +1367,26 @@ static inline u64 irq_time_read(int cpu) > > #ifdef CONFIG_SCHED_POWER > extern void power_late_callback(int cpu); > +extern int at_max_capacity(int cpu); > +extern int go_faster(int cpu, int hint); > +extern int go_slower(int cpu, int hint); > #else > static inline void power_late_callback(int cpu) > { > } > + > +static inline int at_max_capacity(int cpu) > +{ > + return 1; > +} > + > +static inline int go_faster(int cpu, int hint) > +{ > + return 0; > +} > + > +static inline int go_slower(int cpu, int hint) > +{ > + return 0; > +} > #endif /* CONFIG_SCHED_POWER */ >
| |