| Date | Thu, 10 Oct 2013 08:56:09 +0200 | From | Ingo Molnar <> | Subject | Re: [PATCH 15/52] tools/perf/build: Split out feature check: 'libelf-mmap' |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> On Tue, 8 Oct 2013 12:10:45 +0200, Ingo Molnar wrote: > > @@ -202,7 +203,7 @@ ifndef NO_LIBELF > > CFLAGS += -DHAVE_LIBELF_SUPPORT > > FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS) > > > > - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y) > > + ifeq ($(feature-libelf-mmap), 1) > > CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT > > endif > > > > @@ -227,8 +228,7 @@ endif # NO_LIBELF > > > > ifndef NO_LIBELF > > CFLAGS += -DHAVE_LIBELF_SUPPORT > > - FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS) > > - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y) > > + ifeq ($(feature-libelf-mmap), 1) > > CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT > > endif # try-cc > > endif # NO_LIBELF > > As Ulrich Drepper reported, it seems that this hunk is duplicate.
This was pre-existing, but indeed it's an unnecessary duplication. I'll send a patch in a separate mail.
Thanks,
Ingo
|