lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 15/52] tools/perf/build: Split out feature check: 'libelf-mmap'

* Namhyung Kim <namhyung@kernel.org> wrote:

> On Tue, 8 Oct 2013 12:10:45 +0200, Ingo Molnar wrote:
> > @@ -202,7 +203,7 @@ ifndef NO_LIBELF
> > CFLAGS += -DHAVE_LIBELF_SUPPORT
> > FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
> >
> > - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> > + ifeq ($(feature-libelf-mmap), 1)
> > CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> > endif
> >
> > @@ -227,8 +228,7 @@ endif # NO_LIBELF
> >
> > ifndef NO_LIBELF
> > CFLAGS += -DHAVE_LIBELF_SUPPORT
> > - FLAGS_LIBELF=$(CFLAGS) $(LDFLAGS) $(EXTLIBS)
> > - ifeq ($(call try-cc,$(SOURCE_ELF_MMAP),$(FLAGS_LIBELF),-DHAVE_LIBELF_MMAP_SUPPORT),y)
> > + ifeq ($(feature-libelf-mmap), 1)
> > CFLAGS += -DHAVE_LIBELF_MMAP_SUPPORT
> > endif # try-cc
> > endif # NO_LIBELF
>
> As Ulrich Drepper reported, it seems that this hunk is duplicate.

This was pre-existing, but indeed it's an unnecessary duplication. I'll
send a patch in a separate mail.

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-10-10 09:21    [W:0.565 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site