[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH RFC 50/77] mlx5: Update MSI/MSI-X interrupts enablement code
On Thu, Oct 03, 2013 at 09:48:39PM +0200, Alexander Gordeev wrote:
> pci_enable_msix() may fail, but it can not return a positive number.

That is true according to the current logic but the comment on top of
pci_enable_msix() still says:
"A return of < 0 indicates a failure. Or a return of > 0 indicates
that driver request is exceeding the number of irqs or MSI-X vectors

So you're counting on an implementation that may change in the future.
I think leaving the code as it is now is safer.

 \ /
  Last update: 2013-10-10 18:01    [W:0.076 / U:15.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site