lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 3/3] arm64: include: asm: atomic.h: use 'unsigned int' and 'atomic_t' instead of 'unsigned long' for atomic_clear_mask()
    On Thu, Oct 10, 2013 at 03:35:21AM +0100, Chen Gang wrote:
    > In current kernel wide source, for arm64, only s390 scsi drivers use
    > atomic_clear_mask(), now, s390 itself need use 'unsigned int' and
    > 'atomic_t', so need match s390's atomic_clear_mask().
    >
    >
    > Signed-off-by: Chen Gang <gang.chen@asianux.com>
    > ---
    > arch/arm64/include/asm/atomic.h | 13 +++++++------
    > 1 files changed, 7 insertions(+), 6 deletions(-)
    >
    > diff --git a/arch/arm64/include/asm/atomic.h b/arch/arm64/include/asm/atomic.h
    > index 8363644..58808fc 100644
    > --- a/arch/arm64/include/asm/atomic.h
    > +++ b/arch/arm64/include/asm/atomic.h
    > @@ -126,16 +126,17 @@ static inline int atomic_cmpxchg(atomic_t *ptr, int old, int new)
    > return oldval;
    > }
    >
    > -static inline void atomic_clear_mask(unsigned long mask, unsigned long *addr)
    > +static inline void atomic_clear_mask(unsigned int mask, atomic_t *ptr)
    > {
    > - unsigned long tmp, tmp2;
    > + unsigned int tmp;

    Same comment here as for ARM; I think you want a signed int.

    Will


    \
     
     \ /
      Last update: 2013-10-10 12:21    [W:3.231 / U:0.152 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site