Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 50/52] tools/perf/build: Fix O=/some/dir perf.o type of targets | Date | Thu, 10 Oct 2013 17:43:04 +0900 |
| |
Hi,
On Thu, 10 Oct 2013 08:39:18 +0200, Ingo Molnar wrote: > Yes, this is a limitation: it will only do the redirection if the source > repository is clean. > > I don't see a simple solution for that, do you? > >> > +util/%.o: $(OUTPUT)util/%.o >> > + @echo " # Redirected target $@ => $(OUTPUT)util/$@" >> > +bench/%.o: $(OUTPUT)bench/%.o >> > + @echo " # Redirected target $@ => $(OUTPUT)bench/$@" >> > +tests/%.o: $(OUTPUT)tests/%.o >> > + @echo " # Redirected target $@ => $(OUTPUT)tests/$@" >> > +endif >> >> It also doesn't care about other directories - arch/, scripts/ and ui/ - >> and their subdirectories. So even on clean build it'll failed to build >> these files with O=dir. > > Correct - only tried to cover the most common cases. Could add all the > other directories if this is something people would like to use on a > regular basis.
I don't think it's a common usecase.
> > I also attempted to do a generic rule that can see into subdirectories, > using secondary expansion rules, but my first few attempts failed at > producing anything usable ;-) My Make fu still needs working on. > Suggestions welcome!
Well, my make fu (make skill?) is also poor. ;)
I'll try to do something about it though.
Thanks, Namhyung
| |