lkml.org 
[lkml]   [2013]   [Oct]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 50/52] tools/perf/build: Fix O=/some/dir perf.o type of targets
    Date
    Hi,

    On Thu, 10 Oct 2013 08:39:18 +0200, Ingo Molnar wrote:
    > Yes, this is a limitation: it will only do the redirection if the source
    > repository is clean.
    >
    > I don't see a simple solution for that, do you?
    >
    >> > +util/%.o: $(OUTPUT)util/%.o
    >> > + @echo " # Redirected target $@ => $(OUTPUT)util/$@"
    >> > +bench/%.o: $(OUTPUT)bench/%.o
    >> > + @echo " # Redirected target $@ => $(OUTPUT)bench/$@"
    >> > +tests/%.o: $(OUTPUT)tests/%.o
    >> > + @echo " # Redirected target $@ => $(OUTPUT)tests/$@"
    >> > +endif
    >>
    >> It also doesn't care about other directories - arch/, scripts/ and ui/ -
    >> and their subdirectories. So even on clean build it'll failed to build
    >> these files with O=dir.
    >
    > Correct - only tried to cover the most common cases. Could add all the
    > other directories if this is something people would like to use on a
    > regular basis.

    I don't think it's a common usecase.

    >
    > I also attempted to do a generic rule that can see into subdirectories,
    > using secondary expansion rules, but my first few attempts failed at
    > producing anything usable ;-) My Make fu still needs working on.
    > Suggestions welcome!

    Well, my make fu (make skill?) is also poor. ;)

    I'll try to do something about it though.

    Thanks,
    Namhyung


    \
     
     \ /
      Last update: 2013-10-10 11:01    [W:3.625 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site