Messages in this thread Patch in this message | | | Date | Thu, 10 Oct 2013 15:56:18 +0800 | From | Dong Zhu <> | Subject | Re: [PATCH v4] timer stats: add a 'status' line to timer usage statistics |
| |
> > > I suspect we could do something like: > > > > > > seq_printf("Status: collection %s\n", timer_stats_active ? "enabled" : "disabled"); > > > > > > and save a bit of kernel image size? > > > > > > Also, please bump up the version to v0.3, to give parsers a chance. > > I think you forgot about this suggestion of mine. >
Oh, oops, sorry about that.
I modified the patch again as below, hope it could be applied this time.
From 92a67f74766e02b5f4702b1af2af9861bf70d60b Mon Sep 17 00:00:00 2001 From: Dong Zhu <bluezhudong@gmail.com> Date: Thu, 10 Oct 2013 15:48:29 +0800
We can enable|disable timer statistics collection (via echo [1|0] > /proc/timers_stats), this patch adds a 'status' line to display the current timer collection status. In the meantime I also bump up the timer stats version to v0.3.
Signed-off-by: Dong Zhu <bluezhudong@gmail.com> --- kernel/time/timer_stats.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/time/timer_stats.c b/kernel/time/timer_stats.c index 0b537f2..7c31ab7 100644 --- a/kernel/time/timer_stats.c +++ b/kernel/time/timer_stats.c @@ -298,11 +298,13 @@ static int tstats_show(struct seq_file *m, void *v) period = ktime_to_timespec(time); ms = period.tv_nsec / 1000000; - seq_puts(m, "Timer Stats Version: v0.2\n"); + seq_puts(m, "Timer Stats Version: v0.3\n"); seq_printf(m, "Sample period: %ld.%03ld s\n", period.tv_sec, ms); if (atomic_read(&overflow_count)) seq_printf(m, "Overflow: %d entries\n", atomic_read(&overflow_count)); + seq_printf(m, "Status: collection %s\n", + timer_stats_active ? "enabled" : "disabled"); for (i = 0; i < nr_entries; i++) { entry = entries + i; -- 1.7.11.7
-- Best Regards, Dong Zhu
| |