lkml.org 
[lkml]   [2013]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Staging: android: binder.c: Fixed 80 characters warnings from checkpatch.pl
From
Date
On Tue, 2013-10-01 at 21:39 -0400, Mathieu Rhéaume wrote:
> Fixed a lot of warnings from checkpatch.pl about the 80 characters per line limitation.

I'd prefer
s/binder_user_error/binder_user_err/
or
s/binder_user_error/binder_err/

without doing the strange wrapping

checkpatch will then exclude these long line formats from
line length checking.

> diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
[]
> @@ -663,7 +663,8 @@ static struct binder_buffer *binder_alloc_buf(struct binder_proc *proc,
> ALIGN(offsets_size, sizeof(void *));
>
> if (size < data_size || size < offsets_size) {
> - binder_user_error("%d: got transaction with invalid size %zd-%zd\n",
> + binder_user_error(
> + "%d: got transaction with invalid size %zd-%zd\n",
> proc->pid, data_size, offsets_size);

IMO - not an improvement


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-10-02 04:01    [W:0.043 / U:8.552 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site