Messages in this thread | | | From | Peter Hüwe <> | Subject | Re: [PATCH 08/13] tpm: Pull everything related to /dev/tpmX into tpm-dev.c | Date | Wed, 2 Oct 2013 00:52:40 +0200 |
| |
Am Montag, 23. September 2013, 20:14:38 schrieb Jason Gunthorpe: > CLASS-dev.c is a common idiom for Linux subsystems > > This pulls all the code related to the miscdev into tpm-dev.c and makes it > static. The identical file_operation structs in the drivers are purged and > the tpm common code unconditionally creates the miscdev. > > Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> > --- > drivers/char/tpm/Makefile | 2 +- > drivers/char/tpm/tpm-dev.c | 199
When compiling the tpm drivers as modules I get ERROR: "tpm_sysfs_del_device" [drivers/char/tpm/tpm.ko] undefined! ERROR: "tpm_dev_add_device" [drivers/char/tpm/tpm.ko] undefined! ERROR: "tpm_dev_del_device" [drivers/char/tpm/tpm.ko] undefined! ERROR: "tpm_sysfs_add_device" [drivers/char/tpm/tpm.ko] undefined! ERROR: "tpm_transmit" [drivers/char/tpm/tpm-sysfs.ko] undefined! ERROR: "tpm_pcr_read_dev" [drivers/char/tpm/tpm-sysfs.ko] undefined! ERROR: "tpm_getcap" [drivers/char/tpm/tpm-sysfs.ko] undefined! ERROR: "tpm_transmit" [drivers/char/tpm/tpm-dev.ko] undefined!
I added a suitable patch with the appropriate EXPORT_SYMBOL_GPL declarations to my testing branch. (also see next message)
Thanks, Peter
| |