lkml.org 
[lkml]   [2013]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [BUG] Regression in 2fdac010 drivers/net/ethernet/via/via-velocity.c: update napi implementation
Julia Lawall <julia.lawall@lip6.fr> :
[...]
> There has already been a discussion about this, and a patch has already
> been proposed. It has to do with lock managament. I will look for the
> email.

The underlying problem has to do with disabled irq. netif_receive_skb
assumes irq to be enabled. Current via-velocity poll() method should
narrow its (spinlocked) irq disabled section.

What I've done should not require much analysis (aka "what could race
with the rx bh processing in a napi driver ?") and avoids a more intrusive
lockless napi design.

--
Ueimor


\
 
 \ /
  Last update: 2013-10-02 01:01    [W:0.071 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site