Messages in this thread | | | Date | Thu, 10 Jan 2013 10:18:40 +0800 | From | Tang Chen <> | Subject | Re: [PATCH v6 00/15] memory-hotplug: hot-remove physical memory |
| |
Hi Andrew,
On 01/10/2013 07:33 AM, Andrew Morton wrote: > On Wed, 9 Jan 2013 17:32:24 +0800 > Tang Chen<tangchen@cn.fujitsu.com> wrote: > >> This patch-set aims to implement physical memory hot-removing. > > As you were on th patch delivery path, all of these patches should have > your Signed-off-by:. But some were missing it. I fixed this in my > copy of the patches.
Thank you very much for the help. Next time I'll add it myself.
> > > I suspect this patchset adds a significant amount of code which will > not be used if CONFIG_MEMORY_HOTPLUG=n. "[PATCH v6 06/15] > memory-hotplug: implement register_page_bootmem_info_section of > sparse-vmemmap", for example. This is not a good thing, so please go > through the patchset (in fact, go through all the memhotplug code) and > let's see if we can reduce the bloat for CONFIG_MEMORY_HOTPLUG=n > kernels. > > This needn't be done immediately - it would be OK by me if you were to > defer this exercise until all the new memhotplug code is largely in > place. But please, let's do it.
OK, I'll do have a check on it when the page_cgroup problem is solved.
Thanks. :)
> > >
| |