lkml.org 
[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] uprobes: Move alloc_page() from xol_add_vma() to xol_alloc_area()
* Oleg Nesterov <oleg@redhat.com> [2013-01-08 18:58:22]:

> On 01/08, Srikar Dronamraju wrote:
> >
> > (One simple check below)
> >
> > Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>
> Thanks,
>
> > > @@ -1072,11 +1064,8 @@ static int xol_add_vma(struct xol_area *area)
> > > smp_wmb(); /* pairs with get_xol_area() */
> > > mm->uprobes_state.xol_area = area;
> > > ret = 0;
> > > -
> > > -fail:
> > > + fail:
> >
> > Not sure if the space before label is intentional?
> > Its true of other labels below also.
>
> Yes, this was intentional although almost subconscious.
>
> Personally I prefer to add a space before the label, this helps
> /usr/bin/diff to not confuse this label with the function name.
>
> But I can stop this if you dislike.

I dont have any preference. Just wanted to check if it was intentional
or accidental. I thought checkpatch.pl cribs for this.
I think somebody while reviewing my patches had pointed out the same to me.
I cant remember who and probably my format wasnt just a single space
before label.

>
> Oleg.
>



\
 
 \ /
  Last update: 2013-01-09 19:01    [W:0.069 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site