lkml.org 
[lkml]   [2013]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [resend][PATCH 03/16] dmaengine: introduce is_slave_xfer function
From
n 9 January 2013 19:20, Vinod Koul <vinod.koul@intel.com> wrote:
>> +static inline bool is_slave_xfer(enum dma_transfer_direction direction)
>> +{
>> + return (direction == DMA_MEM_TO_DEV) || (direction == DMA_DEV_TO_MEM);
>> +}
> After reading the subsequent patch I understand what is intent here. Perhaps
> is_slave_dirn() would have been a beter one...

dirn isn't readable, it took me some time to understand the intent...
Either have xfer or direction :)


\
 
 \ /
  Last update: 2013-01-09 16:01    [W:0.132 / U:2.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site