lkml.org 
[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[v2.6.34-stable 16/77] inotify: stop kernel memory leak on file creation failure
    Date
    From: Eric Paris <eparis@redhat.com>

    -------------------
    This is a commit scheduled for the next v2.6.34 longterm release.
    http://git.kernel.org/?p=linux/kernel/git/paulg/longterm-queue-2.6.34.git
    If you see a problem with using this for longterm, please comment.
    -------------------

    commit a2ae4cc9a16e211c8a128ba10d22a85431f093ab upstream.

    If inotify_init is unable to allocate a new file for the new inotify
    group we leak the new group. This patch drops the reference on the
    group on file allocation failure.

    Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
    Signed-off-by: Eric Paris <eparis@redhat.com>
    Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
    ---
    fs/notify/inotify/inotify_user.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/fs/notify/inotify/inotify_user.c b/fs/notify/inotify/inotify_user.c
    index 0c6bbc0..72f8825 100644
    --- a/fs/notify/inotify/inotify_user.c
    +++ b/fs/notify/inotify/inotify_user.c
    @@ -674,6 +674,7 @@ SYSCALL_DEFINE1(inotify_init1, int, flags)
    if (ret >= 0)
    return ret;

    + fsnotify_put_group(group);
    atomic_dec(&user->inotify_devs);
    out_free_uid:
    free_uid(user);
    --
    1.7.12.1


    \
     
     \ /
      Last update: 2013-01-09 01:21    [W:4.166 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site