lkml.org 
[lkml]   [2013]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Added NIST CMAC to the CryptoAPI library
Hi all,

I agree with the ^ comment ... I'll look into the "styles" issue, though ironically I would consider that a maintainers job...

I'll resend a bit later today.

Tom

----- Original Message -----
> From: "Steffen Klassert" <steffen.klassert@secunet.com>
> To: "Tom St Denis" <tstdenis@elliptictech.com>
> Cc: linux-kernel@vger.kernel.org, davem@davemloft.net, herbert@gondor.apana.org.au
> Sent: Tuesday, 8 January, 2013 3:54:25 AM
> Subject: Re: [PATCH] Added NIST CMAC to the CryptoAPI library
>
> On Tue, Dec 11, 2012 at 02:00:10PM -0500, Tom St Denis wrote:
> > This patch adds NIST CMAC cipher based MAC as described in FIPS
> > 800-38B to
> > the CryptoAPI stack. It also wires up the MAC to the IPsec stack
> > as per
> > RFC 4494.
> >
> > This patch was tested against 3.7 with third party hardware IPsec.
> >
> > Signed-off-by: Tom St Denis <tstdenis@elliptictech.com>
> > Acked-by: David S. Miller <davem@davemloft.net>
> >
>
> I agreed with Herbert Xu to integrate this via the ipsec-next tree.
>
> However, it introduces the following warning:
>
> crypto/cmac.c: In function ‘crypto_cmac_digest_setkey’:
> crypto/cmac.c:97:4: warning: suggest parentheses around arithmetic in
> operand of ‘^’ [-Wparentheses]
>
> It also has a lot of coding style issues, run checkpatch.
>
> Please fix it and resend.
>
> Thanks!
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-01-08 12:41    [W:0.059 / U:1.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site