lkml.org 
[lkml]   [2013]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/33] sched: Update rq clock on nohz CPU before setting fair group shares
    Date
    Because we may update the execution time (sched_group_set_shares()->
    update_cfs_shares()->reweight_entity()->update_curr()) before
    reweighting the entity after updating the group shares and this requires
    an uptodate version of the runqueue clock. Let's update it on the target
    CPU if it runs tickless because scheduler_tick() is not there to maintain
    it.

    Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
    Cc: Alessio Igor Bogani <abogani@kernel.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    Cc: Chris Metcalf <cmetcalf@tilera.com>
    Cc: Christoph Lameter <cl@linux.com>
    Cc: Geoff Levand <geoff@infradead.org>
    Cc: Gilad Ben Yossef <gilad@benyossef.com>
    Cc: Hakan Akkan <hakanakkan@gmail.com>
    Cc: Ingo Molnar <mingo@kernel.org>
    Cc: Li Zhong <zhong@linux.vnet.ibm.com>
    Cc: Namhyung Kim <namhyung.kim@lge.com>
    Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
    Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Steven Rostedt <rostedt@goodmis.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    ---
    kernel/sched/fair.c | 5 +++++
    1 files changed, 5 insertions(+), 0 deletions(-)

    diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
    index 5eea870..a96f0f2 100644
    --- a/kernel/sched/fair.c
    +++ b/kernel/sched/fair.c
    @@ -6068,6 +6068,11 @@ int sched_group_set_shares(struct task_group *tg, unsigned long shares)
    se = tg->se[i];
    /* Propagate contribution to hierarchy */
    raw_spin_lock_irqsave(&rq->lock, flags);
    + /*
    + * We may call update_curr() which needs an up-to-date
    + * version of rq clock if the CPU runs tickless.
    + */
    + update_nohz_rq_clock(rq);
    for_each_sched_entity(se)
    update_cfs_shares(group_cfs_rq(se));
    raw_spin_unlock_irqrestore(&rq->lock, flags);
    --
    1.7.5.4


    \
     
     \ /
      Last update: 2013-01-08 03:41    [W:4.119 / U:1.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site