lkml.org 
[lkml]   [2013]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/4] input: keyboard: tegra: use devm_* for resource allocation
    On Sat, Jan 05, 2013 at 12:06:58AM -0800, Dmitry Torokhov wrote:
    > On Sat, Jan 05, 2013 at 01:15:08PM +0530, Laxman Dewangan wrote:
    [...]
    > > @@ -735,25 +738,16 @@ static int tegra_kbc_probe(struct platform_device *pdev)
    > > spin_lock_init(&kbc->lock);
    > > setup_timer(&kbc->timer, tegra_kbc_keypress_timer, (unsigned long)kbc);
    > >
    > > - res = request_mem_region(res->start, resource_size(res), pdev->name);
    > > - if (!res) {
    > > - dev_err(&pdev->dev, "failed to request I/O memory\n");
    > > - err = -EBUSY;
    > > - goto err_free_mem;
    > > - }
    > > -
    > > - kbc->mmio = ioremap(res->start, resource_size(res));
    > > + kbc->mmio = devm_request_and_ioremap(&pdev->dev, res);
    > > if (!kbc->mmio) {
    > > - dev_err(&pdev->dev, "failed to remap I/O memory\n");
    > > - err = -ENXIO;
    > > - goto err_free_mem_region;
    > > + dev_err(&pdev->dev, "Cannot request memregion/iomap address\n");
    > > + return -EADDRNOTAVAIL;
    >
    > Erm, no, -EBUSY please.

    EADDRNOTAVAIL is the canonical error for devm_request_and_ioremap()
    failure. The kerneldoc comment in lib/devres.c even gives a short
    example that uses this error code.

    Thierry
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2013-01-06 21:01    [W:3.208 / U:0.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site