Messages in this thread | | | Date | Sat, 5 Jan 2013 15:01:25 -0800 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] drivers/input/keyboard/lm8323.c: fix incorrect left shift |
| |
On Sat, Jan 05, 2013 at 02:09:05PM -0500, Nickolai Zeldovich wrote: > In drivers/input/keyboard/lm8323.c, INT_PWM1 is already a bitmask, > not the bit number, so shifting by INT_PWM1 is incorrect. > > Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Applied, thank you Nickolai.
> --- > drivers/input/keyboard/lm8323.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/keyboard/lm8323.c b/drivers/input/keyboard/lm8323.c > index 93c8126..0de23f4 100644 > --- a/drivers/input/keyboard/lm8323.c > +++ b/drivers/input/keyboard/lm8323.c > @@ -398,7 +398,7 @@ static irqreturn_t lm8323_irq(int irq, void *_lm) > lm8323_configure(lm); > } > for (i = 0; i < LM8323_NUM_PWMS; i++) { > - if (ints & (1 << (INT_PWM1 + i))) { > + if (ints & (INT_PWM1 << i)) { > dev_vdbg(&lm->client->dev, > "pwm%d engine completed\n", i); > pwm_done(&lm->pwm[i]); > -- > 1.7.10.4 >
-- Dmitry
| |