Messages in this thread | | | From | "Myklebust, Trond" <> | Subject | Re: [PATCH] nfs: avoid dereferencing null pointer in initiate_bulk_draining | Date | Sat, 5 Jan 2013 19:29:20 +0000 |
| |
On Sat, 2013-01-05 at 14:19 -0500, Nickolai Zeldovich wrote: > Fix an inverted null pointer check in initiate_bulk_draining(). > > Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu> > --- > fs/nfs/callback_proc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/nfs/callback_proc.c b/fs/nfs/callback_proc.c > index c89b26b..264d1aa 100644 > --- a/fs/nfs/callback_proc.c > +++ b/fs/nfs/callback_proc.c > @@ -206,7 +206,7 @@ static u32 initiate_bulk_draining(struct nfs_client *clp, > > list_for_each_entry(lo, &server->layouts, plh_layouts) { > ino = igrab(lo->plh_inode); > - if (ino) > + if (!ino) > continue; > spin_lock(&ino->i_lock); > /* Is this layout in the process of being freed? */
Thanks for spotting. Applied to the 'bugfixes' branch.
-- Trond Myklebust Linux NFS client maintainer
NetApp Trond.Myklebust@netapp.com www.netapp.com
| |