lkml.org 
[lkml]   [2013]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rcutorture: don't compare ptr with 0
On Thu, Dec 20, 2012 at 02:39:12PM -0800, Josh Triplett wrote:
> On Thu, Dec 20, 2012 at 02:11:28PM -0500, Sasha Levin wrote:
> > Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
>
> Fair enough. You might as well change the first half of the conditional
> too, though. In any case:
>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>

Queued, thank you both!

Thanx, Paul

> > kernel/rcutorture.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/kernel/rcutorture.c b/kernel/rcutorture.c
> > index 31dea01..0249800 100644
> > --- a/kernel/rcutorture.c
> > +++ b/kernel/rcutorture.c
> > @@ -1749,7 +1749,7 @@ static int rcu_torture_barrier_init(void)
> > barrier_cbs_wq =
> > kzalloc(n_barrier_cbs * sizeof(barrier_cbs_wq[0]),
> > GFP_KERNEL);
> > - if (barrier_cbs_tasks == NULL || barrier_cbs_wq == 0)
> > + if (barrier_cbs_tasks == NULL || !barrier_cbs_wq)
> > return -ENOMEM;
> > for (i = 0; i < n_barrier_cbs; i++) {
> > init_waitqueue_head(&barrier_cbs_wq[i]);
> > --
> > 1.8.0
> >
>



\
 
 \ /
  Last update: 2013-01-04 19:01    [W:0.073 / U:1.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site