Messages in this thread | | | Date | Thu, 31 Jan 2013 10:09:59 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH v8 2/4] block: add runtime pm helpers |
| |
On Thu, 31 Jan 2013, Aaron Lu wrote:
> > > +void blk_pm_runtime_init(struct request_queue *q, struct device *dev) > > > +{ > > > + q->dev = dev; > > > + q->rpm_status = RPM_ACTIVE; > > > + pm_runtime_set_autosuspend_delay(q->dev, -1); > > > + pm_runtime_use_autosuspend(q->dev); > > > + pm_runtime_mark_last_busy(q->dev); > > > + pm_runtime_autosuspend(q->dev); > > > > This last line is no longer needed. It can't do anything useful, since > > autosuspends are disabled (the delay is -1). > > Right, thanks. > And the mark_last_busy can probably be removed too, it didn't make much > sense here and we can add "driver should call pm_runtime_mark_last_busy > and pm_runtime_autosuspend in its runtime idle callback" to the kernel > doc. What do you think?
Yes, okay.
Alan Stern
| |