lkml.org 
[lkml]   [2013]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 2/4] block: add runtime pm helpers
On Thu, 31 Jan 2013, Aaron Lu wrote:

> > > +void blk_pm_runtime_init(struct request_queue *q, struct device *dev)
> > > +{
> > > + q->dev = dev;
> > > + q->rpm_status = RPM_ACTIVE;
> > > + pm_runtime_set_autosuspend_delay(q->dev, -1);
> > > + pm_runtime_use_autosuspend(q->dev);
> > > + pm_runtime_mark_last_busy(q->dev);
> > > + pm_runtime_autosuspend(q->dev);
> >
> > This last line is no longer needed. It can't do anything useful, since
> > autosuspends are disabled (the delay is -1).
>
> Right, thanks.
> And the mark_last_busy can probably be removed too, it didn't make much
> sense here and we can add "driver should call pm_runtime_mark_last_busy
> and pm_runtime_autosuspend in its runtime idle callback" to the kernel
> doc. What do you think?

Yes, okay.

Alan Stern



\
 
 \ /
  Last update: 2013-01-31 17:01    [W:0.051 / U:1.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site