Messages in this thread | | | Subject | Re: [PATCH] checkpatch: fix USLEEP_RANGE test | From | Joe Perches <> | Date | Wed, 30 Jan 2013 20:55:07 -0800 |
| |
On Wed, 2013-01-30 at 11:15 -0800, Bruce Allan wrote: > Do not test udelay() for a value less than 10usec when passed a variable > instead of a hard-coded number; [] > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > @@ -3237,9 +3237,9 @@ sub process { [] > # prefer usleep_range over udelay > - if ($line =~ /\budelay\s*\(\s*(\w+)\s*\)/) { > + if ($line =~ /\budelay\s*\(\s*(\d+)\s*\)/) { > # ignore udelay's < 10, however > - if (! (($1 =~ /(\d+)/) && ($1 < 10)) ) { > + if (! ($1 < 10) ) { > CHK("USLEEP_RANGE", > "usleep_range is preferred over udelay; see Documentation/timers/timers-howto.txt\n" . $line); > }
Thanks Bruce.
Just a trivial comment:
Maybe this would be a little neater as
if ($line =~ \budelay\s*\(\s*(\d+)\s*\) && $1 >= 10) { CHK(etc...) }
No worries though.
| |