lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] staging: zsmalloc: remove unused pool name
On Wed, Jan 30, 2013 at 06:21:59PM +0100, Greg Kroah-Hartman wrote:
> On Wed, Jan 30, 2013 at 09:41:55AM -0600, Seth Jennings wrote:
> > On 01/30/2013 09:36 AM, Seth Jennings wrote:> zs_create_pool()
> > currently takes a name argument which is
> > > never used in any useful way.
> > >
> > > This patch removes it.
> > >
> > > Signed-off-by: Seth Jennings <sjenning@linux.vnet.ibm.com>
> >
> > Crud, forgot the Acks...
> >
> > Acked-by: Nitin Gupta <ngupta@vflare.org>
> > Acked-by: Rik van Riel <riel@redhat.com>
>
> {sigh} you just made me have to edit your patch by hand, you now owe me
> a beer...
>
Should we codify that :-)


diff --git a/Documentation/SubmittingPatches b/Documentation/SubmittingPatches
index c379a2a..f879c60 100644
--- a/Documentation/SubmittingPatches
+++ b/Documentation/SubmittingPatches
@@ -94,6 +94,7 @@ includes updates for subsystem X. Please apply."
The maintainer will thank you if you write your patch description in a
form which can be easily pulled into Linux's source code management
system, git, as a "commit log". See #15, below.
+If the maintainer has to hand-edit your patch, you owe them a beer.

If your description starts to get long, that's a sign that you probably
need to split up your patch. See #3, next.

\
 
 \ /
  Last update: 2013-01-30 19:01    [W:0.061 / U:0.908 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site