lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v2 1/2] ARM: Exynos5250: Enabling samsung-usbphy driver
Date
Vivek Gautam wrote:
>
> Adding usbphy node for Exynos5250 along with the
> necessary device data to be parsed.
>
> Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
> ---
> arch/arm/boot/dts/exynos5250.dtsi | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi
> index 30485de..610e338 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -275,6 +275,21 @@
> #size-cells = <0>;
> };
>
> + usbphy@12130000 {

Please put above node by order of address.

> + compatible = "samsung,exynos5250-usbphy";
> + reg = <0x12130000 0x100>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + usbphy-sys {
> + /* USB device and host PHY_CONTROL registers
*/

Please add the binding documentation instead of comment here.

> + reg = <0x10040704 0x8>,
> + /* USB2.0 PHY configuration register */
> + <0x10050230 0x4>;
> + };
> + };
> +
> amba {
> #address-cells = <1>;
> #size-cells = <1>;
> --
> 1.7.6.5



\
 
 \ /
  Last update: 2013-01-30 07:01    [W:0.332 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site