Messages in this thread | | | Date | Wed, 30 Jan 2013 10:43:51 +0000 | From | James Hogan <> | Subject | Re: [PATCH v3 43/44] tty/metag_da: Add metag DA TTY driver |
| |
On 30/01/13 05:14, Greg Kroah-Hartman wrote: > On Fri, Jan 25, 2013 at 11:36:53AM +0000, James Hogan wrote: >> Hi, >> >> On 14/01/13 10:54, James Hogan wrote: >>> Here's a new version addressing Jiri's feedback. >>> >>> Add a TTY driver for communicating over a Meta DA (Debug Adapter) >>> channel using the bios channel SWITCH operation. >>> >>> Signed-off-by: James Hogan <james.hogan@imgtec.com> >>> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Jiri Slaby <jslaby@suse.cz> >>> Cc: Andrew Morton <akpm@linux-foundation.org> >>> Cc: Mauro Carvalho Chehab <mchehab@redhat.com> >>> Cc: Cesar Eduardo Barros <cesarb@cesarb.net> >>> Cc: Joe Perches <joe@perches.com> >>> Cc: "David S. Miller" <davem@davemloft.net> >> >> If this looks okay, I'd appreciate if somebody could Ack it. >> >> I have some further patches ready to simplify the code around >> tty_prepare_flip_string and tty_flip_buffer_push to avoid taking a tty >> kref, after Jiri's changes in that area in linux-next. I guess these can >> be applied once both sets of changes are merged. > > At first glance, it looks good to me: > > Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >
Thanks Greg.
Cheers James
| |