lkml.org 
[lkml]   [2013]   [Jan]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 43/44] tty/metag_da: Add metag DA TTY driver
On Fri, Jan 25, 2013 at 11:36:53AM +0000, James Hogan wrote:
> Hi,
>
> On 14/01/13 10:54, James Hogan wrote:
> > Here's a new version addressing Jiri's feedback.
> >
> > Add a TTY driver for communicating over a Meta DA (Debug Adapter)
> > channel using the bios channel SWITCH operation.
> >
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jiri Slaby <jslaby@suse.cz>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> > Cc: Cesar Eduardo Barros <cesarb@cesarb.net>
> > Cc: Joe Perches <joe@perches.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
>
> If this looks okay, I'd appreciate if somebody could Ack it.
>
> I have some further patches ready to simplify the code around
> tty_prepare_flip_string and tty_flip_buffer_push to avoid taking a tty
> kref, after Jiri's changes in that area in linux-next. I guess these can
> be applied once both sets of changes are merged.

At first glance, it looks good to me:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


\
 
 \ /
  Last update: 2013-01-30 10:21    [W:0.077 / U:5.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site