Messages in this thread | | | Date | Thu, 3 Jan 2013 15:42:42 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v3 6/8] MFD:rtsx: Add callback function conv_clk_and_div_n |
| |
On Fri, Dec 28, 2012 at 10:41:45AM +0800, wei_wang@realsil.com.cn wrote: > diff --git a/drivers/mfd/rts5209.c b/drivers/mfd/rts5209.c > index ba74de8..98fe0f3 100644 > --- a/drivers/mfd/rts5209.c > +++ b/drivers/mfd/rts5209.c > @@ -174,6 +174,7 @@ static const struct pcr_ops rts5209_pcr_ops = { > .card_power_off = rts5209_card_power_off, > .switch_output_voltage = rts5209_switch_output_voltage, > .cd_deglitch = NULL, > + .conv_clk_and_div_n = NULL,
This isn't needed. It's set to NULL by default.
> - N = (u8)(clk - 2); > + if (pcr->ops->conv_clk_and_div_n) > + N = (u8)pcr->ops->conv_clk_and_div_n(clk, CLK_TO_DIV_N); > + else > + N = (u8)(clk - 2);
These unneeded casts are confusing. Why are we doing them anyway?
regards, dan carpenter
| |