lkml.org 
[lkml]   [2013]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -v2 03/26] x86: pageattr-test: remove srandom32 call
    Date
    pageattr-test calls srandom32() once every test iteration.
    But calling srandom32() after late_initcalls is not meaningfull.
    Because the random states for random32() is mixed by good random numbers
    in late_initcall prandom_reseed().

    So this removes the call to srandom32().

    Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: "H. Peter Anvin" <hpa@zytor.com>
    Cc: x86@kernel.org
    ---

    No change from v1

    arch/x86/mm/pageattr-test.c | 1 -
    1 file changed, 1 deletion(-)

    diff --git a/arch/x86/mm/pageattr-test.c b/arch/x86/mm/pageattr-test.c
    index b008656..8b8c381 100644
    --- a/arch/x86/mm/pageattr-test.c
    +++ b/arch/x86/mm/pageattr-test.c
    @@ -130,7 +130,6 @@ static int pageattr_test(void)
    }

    failed += print_split(&sa);
    - srandom32(100);

    for (i = 0; i < NTEST; i++) {
    unsigned long pfn = random32() % max_pfn_mapped;
    --
    1.7.11.7


    \
     
     \ /
      Last update: 2013-01-03 14:01    [W:3.182 / U:0.728 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site