lkml.org 
[lkml]   [2013]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/8] configfs checkpatch cleanup
Date
Dear All,

I noticed that configfs implementation has many style problems:

(checkpatch output edited for clarity)

total: 7 errors, 11 warnings, 260 lines checked
include/linux/configfs.h has style problems, please review.

total: 22 errors, 7 warnings, 160 lines checked
fs/configfs/configfs_internal.h has style problems, please review.

total: 53 errors, 20 warnings, 1756 lines checked
fs/configfs/dir.c has style problems, please review.

total: 45 errors, 16 warnings, 344 lines checked
fs/configfs/file.c has style problems, please review.

total: 19 errors, 7 warnings, 296 lines checked
fs/configfs/inode.c has style problems, please review.

total: 30 errors, 8 warnings, 216 lines checked
fs/configfs/item.c has style problems, please review.

total: 3 errors, 3 warnings, 183 lines checked
fs/configfs/mount.c has style problems, please review.

total: 14 errors, 3 warnings, 314 lines checked
fs/configfs/symlink.c has style problems, please review.

TOTAL: 193 errors, 75 warnings

I had some time at the end of the last year so I made this patch series.

After applying it:

total: 0 errors, 0 warnings, 269 lines checked
include/linux/configfs.h has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 166 lines checked
fs/configfs/configfs_internal.h has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 1766 lines checked
fs/configfs/dir.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 354 lines checked
fs/configfs/file.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 300 lines checked
fs/configfs/inode.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 214 lines checked
fs/configfs/item.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 183 lines checked
fs/configfs/mount.c has no obvious style problems and is ready for submission.

total: 0 errors, 0 warnings, 315 lines checked
fs/configfs/symlink.c has no obvious style problems and is ready for submission.

Andrzej Pietrasiewicz (8):
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup
fs/configfs: checkpatch cleanup

fs/configfs/configfs_internal.h | 54 ++++----
fs/configfs/dir.c | 282 ++++++++++++++++++++-------------------
fs/configfs/file.c | 112 +++++++++-------
fs/configfs/inode.c | 46 ++++---
fs/configfs/item.c | 60 ++++-----
fs/configfs/mount.c | 12 +-
fs/configfs/symlink.c | 29 ++--
include/linux/configfs.h | 37 +++--
8 files changed, 335 insertions(+), 297 deletions(-)



\
 
 \ /
  Last update: 2013-01-03 13:21    [W:0.050 / U:1.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site