Messages in this thread | | | Date | Tue, 29 Jan 2013 09:49:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH] x86/apic: check FADT settings after enable x2apic |
| |
* Wang, Song-Bo (Stoney) <song-bo.wang@hp.com> wrote:
> [...] Due to this mode mismatch, with specific HW > configurations, there will be intermittent lost interrupts, > which could result in a hang or data loss.
That's the key piece of information that was missing - which should be put into the changelog into a very prominent place.
> Logically, there is a mismatch because the kernel missed > detection on HW configurations, and we should fix it, right? > Do we need more detailed information?
No, the above sentence is more than enough and the fix looks nice. Note that this sentence is more useful to users than the rest of the changelog combined!
Thanks,
Ingo
| |