lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC] arm: use built-in byte swap function
    On Tue, Jan 29, 2013 at 05:55:54PM +0000, Woodhouse, David wrote:
    > That's different though. That's because GCC didn't have a generic
    > __builtin_bswap16() until 4.8, while PowerPC got it in 4.6.
    >
    > That's a relatively simple and manageable one-off arch-dependency. But
    > once we get into a mass of "well, it wasn't actually *usable* for ARM
    > until 4.9", we start wanting to push it into arch code.

    Yeah, and once people see one arch mentioned, all of a sudden they think
    it is ok to add just one more ...

    > > But I liked your other suggestion better to get the offending
    > > compilers fixed.
    >
    > That wasn't an *alternative*. It's required if the compiler is doing
    > something suboptimal, whatever happens. And then we start to *use* the
    > compiler from the first version that's known to be fixed.

    So, IMHO it sounds to me like we want to explicitly state for each arch
    separately that it is ok to use the __builtin_bswapXX things. This also
    takes care of the case where the compiler is doing something suboptimal
    by excluding the affected versions.

    Thanks.

    --
    Regards/Gruss,
    Boris.

    Sent from a fat crate under my desk. Formatting is fine.
    --


    \
     
     \ /
      Last update: 2013-01-29 19:41    [W:2.905 / U:0.216 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site