lkml.org 
[lkml]   [2013]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages
    Hillf Danton wrote:
    > On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov
    > <kirill.shutemov@linux.intel.com> wrote:
    > > @@ -443,6 +443,7 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping,
    > > pgoff_t offset, gfp_t gfp_mask)
    > > {
    > > int error;
    > > + int nr = 1;
    > >
    > > VM_BUG_ON(!PageLocked(page));
    > > VM_BUG_ON(PageSwapBacked(page));
    > > @@ -450,31 +451,61 @@ int add_to_page_cache_locked(struct page *page, struct address_space *mapping,
    > > error = mem_cgroup_cache_charge(page, current->mm,
    > > gfp_mask & GFP_RECLAIM_MASK);
    > > if (error)
    > > - goto out;
    > > + return error;
    >
    > Due to PageCompound check, thp could not be charged effectively.
    > Any change added for charging it?

    I've missed this. Will fix.

    --
    Kirill A. Shutemov


    \
     
     \ /
      Last update: 2013-01-29 15:21    [W:4.253 / U:0.524 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site