Messages in this thread | | | Date | Tue, 29 Jan 2013 20:26:09 +0800 | Subject | Re: [PATCH, RFC 06/16] thp, mm: rewrite add_to_page_cache_locked() to support huge pages | From | Hillf Danton <> |
| |
On Mon, Jan 28, 2013 at 5:24 PM, Kirill A. Shutemov <kirill.shutemov@linux.intel.com> wrote: > + page_cache_get(page); > + spin_lock_irq(&mapping->tree_lock); > + page->mapping = mapping; > + if (PageTransHuge(page)) { > + int i; > + for (i = 0; i < HPAGE_CACHE_NR; i++) { > + page_cache_get(page + i); > + page[i].index = offset + i; > + error = radix_tree_insert(&mapping->page_tree, > + offset + i, page + i); > + if (error) { > + page_cache_release(page + i); > + break; > + }
Is page count balanced with the following?
@@ -168,6 +180,9 @@ void delete_from_page_cache(struct page *page)
if (freepage) freepage(page); + if (PageTransHuge(page)) + for (i = 1; i < HPAGE_CACHE_NR; i++) + page_cache_release(page); page_cache_release(page);
| |